Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ANSI colors to match spec #6

Closed
benknoble opened this issue Apr 1, 2018 · 3 comments
Closed

Update ANSI colors to match spec #6

benknoble opened this issue Apr 1, 2018 · 3 comments
Assignees
@benknoble

Comments

@benknoble
Copy link
Member

benknoble commented Apr 1, 2018 •
edited
Loading

Thanks to the spec created by @dsifford , we have the 'standard' ANSI values to use.

This issue tracks bringing Terminal.app in line with said spec.
@benknoble benknoble self-assigned this Apr 1, 2018
@dsifford
Copy link
Member

dsifford commented Apr 2, 2018

The spec document might be outdated. The ANSI colors were adjusted per recommendations of @marcdeop.

See dracula/dracula-theme#232 (comment)

@benknoble
Copy link
Member Author

@dsifford So should I rely on the linked spec or the comment you mentioned ?

@dsifford
Copy link
Member

dsifford commented Apr 3, 2018

The comment should be accurate I think

benknoble added a commit that referenced this issue Apr 3, 2018
@benknoble
Use new spec for colors
581dbe8 
See #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benknoble benknoble

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsifford @benknoble