Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOTD and WHOIS info are not visible on mobile #3

Closed
ghost opened this issue Sep 20, 2021 · 3 comments
Closed

MOTD and WHOIS info are not visible on mobile #3

ghost opened this issue Sep 20, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Sep 20, 2021

MOTD and WHOIS info is not visible in this theme

Screenshot_20210919-203258_Chrome
Screenshot_20210919-203320_Chrome
@ronilaukkarinen
Copy link
Collaborator

ronilaukkarinen commented Sep 20, 2021 •
edited
Loading

It seems this is due to the default table-like list data structure. In default theme it's also like this but without the main cell that aligns the items and with smaller font so they with side by side.

One option is to remove all margins/gaps on mobile and make the font size as small as possible. We could perhaps remove the "icon column" as well to save space:

Screen-Shot-2021-09-20-08-40-46 73

Should be rather easy to fix but I'm too busy right now and my main focus is currently on midnight theme so right now this is not a top priority for me. Pull requests welcome.

@ronilaukkarinen ronilaukkarinen added the help wanted Extra attention is needed label Sep 20, 2021
@ronilaukkarinen ronilaukkarinen changed the title Colors & fonts MOTD and WHOIS info is not visible in this theme Sep 20, 2021
@ronilaukkarinen ronilaukkarinen changed the title MOTD and WHOIS info is not visible in this theme MOTD and WHOIS info is not visible on mobile Sep 20, 2021
@ronilaukkarinen ronilaukkarinen changed the title MOTD and WHOIS info is not visible on mobile MOTD and WHOIS info are not visible on mobile Sep 20, 2021
@ronilaukkarinen
Copy link
Collaborator

ronilaukkarinen commented Sep 20, 2021 •
edited
Loading

I have renamed the issue accordingly. Please open separate issues on other things, this issue will be about the whois style bug.

@benyafai benyafai mentioned this issue Oct 31, 2022
Merged
ronilaukkarinen added a commit that referenced this issue Oct 31, 2022
@ronilaukkarinen
Merge pull request #5 from benyafai/master
bb84772 
Formatting fixes for #3 and #4
ronilaukkarinen added a commit that referenced this issue Oct 31, 2022
@ronilaukkarinen
Fix MOTD/WHOIS #3, release 1.0.3
5954633
ronilaukkarinen added a commit that referenced this issue Oct 31, 2022
@ronilaukkarinen
Fix MOTD/WHOIS #3, release 1.0.4
9a05d8a
@ronilaukkarinen
Copy link
Collaborator

Fixed in 1.0.4. Thanks @benyafai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronilaukkarinen