Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim colors don't seem right, cursorline too dark #101

Closed
relkochta opened this issue Aug 10, 2018 · 8 comments
Closed

Vim colors don't seem right, cursorline too dark #101

relkochta opened this issue Aug 10, 2018 · 8 comments

Comments

@relkochta
Copy link

What happened

When compared to dracula running in Visual Studio Code, the colors are completely off, plus the cursorline isn't right either.

Screenshot:

image

What I expected to happen

Since it's the same color scheme it should look the same or at least fairly similar in different editors

Machine Info

  • Vim type (vim/gvim/neovim): neovim, same issue in vim
  • Vim version: neovim 0.3.0, vim 8.1
  • OS: Linux earth 4.17.13-gentoo-earth I would like to make an option to use the ANSI colors #1 SMP Wed Aug 8 13:07:54 EDT 2018 x86_64 AMD Ryzen 7 2700X Eight-Core Processor AuthenticAMD GNU/Linux
  • Terminal/Terminal Emulator/VTE: rxvt-unicode, VTE 0.48.4
  • TERM environment variable: rxvt-unicode-256color

I know this is my second opened issue today, but no matter which settings I change I can't seem to get it right. here's my init.vim:

image

@relkochta
Copy link
Author

To clarify, the bottom is VSCode and the top is NeoVIM.

@relkochta
Copy link
Author

Interestingly enough, when installing with the same configuration on MacOS with iTerm2, it yields the same result.

Using the default configuration without t_co, colorterm, etc... set results in:

image

@dsifford
Copy link
Member

dsifford commented Aug 10, 2018

@Lightn1ngStr1ke It's your lucky day. I maintain both the VSCode Dracula and the Vim Dracula theme 😝

Unfortunately, the issues you're pointing out are issues/limitations with syntax implementations across the editors. VSCode's syntax (which is a derivative of textmate) is much more robust than the syntax that Vim provides. So, because of that, syntax definitions are able to get much more detailed.

Speaking specifically to the discrepancies you've pointed out:

  • Python classes and magic methods in Vim are scoped identically to functions, so that's why they're green.
  • self and cls are able to be fixed. I'll add that on the todo list....

Some other notes:

  • Try using syntax enable rather than syntax on (or download and use tpope/vim-sensible)
  • iterm is finnicky. I use a macbook as my secondary machine and I needed to explicitly set TERM in my iterm config to a supported 256-color terminal (which, on my machine, happened to be a custom tmux-256color).

@relkochta
Copy link
Author

@dsifford Thanks so much for all the information and help! I just wanted to confirm that nothing was wrong - the colors in vim seem to work well enough.

Any ideas about the cursorline issue? It seems to work with termguicolors in iTerm, but no dice on rxvt-unicode.

@relkochta
Copy link
Author

@dsifford

May I ask what terminal emulator you use on Linux that it works under?

@benknoble
Copy link
Member

gnome-terminal on Ubuntu works with termguicolors (but not inside tmux)

@dsifford
Copy link
Member

I use Termite on Linux and iTerm2 on Mac OS (mojave) with no issues. My specific configuration can be found here.

@benknoble
Copy link
Member

I'm going to close this since I'm not sure there's any way to make forward progress at the moment. Feel free to reopen if something changes that makes it easier to bring VS Code/vim into alignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants