Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(10i18n): stop leaking shell options
Avoid using shell options in findkeymap, instead of using a wrapper[*] to restore the previous options. Using mapfile and find to generate the list of files also has the benefit of being more readable in this case. [*] Reverted commit 3506476 Original issue description from Michal Hecko <mhecko@redhat.com>: The findkeymap function manipulates the shell options and relies on restoring them using the trap. However, as the function might be called recursively, each recursive invocation changes the signal handler to its own. As the recursion is entered with shell options already modified, the changed trap handler is replaced with restoration to the modified shell options, not the original ones.
- Loading branch information