Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Man page quotes non-functional nvmf parameter names #1831

Closed
niklas88 opened this issue Jun 1, 2022 · 1 comment · Fixed by #1832
Closed

Man page quotes non-functional nvmf parameter names #1831

niklas88 opened this issue Jun 1, 2022 · 1 comment · Fixed by #1832
Labels
bug Our bugs documents Issues requiring updates to documentation

Comments

@niklas88
Copy link

niklas88 commented Jun 1, 2022

In man 7 dracut.cmdline the nvmf parameters are prefixed with rd.:

  • rd.nvmf.hostnqn
  • rd.nvmf.hostid
  • rd.nvmf.discover

The acutal implementation however only looks for nvmf.hostnqn, nvmf.hostid, and nvmf.discover with no rd. prefix.
@niklas88 niklas88 added the documents Issues requiring updates to documentation label Jun 1, 2022
@johannbg johannbg added the bug Our bugs label Jun 1, 2022
@johannbg
Copy link
Collaborator

johannbg commented Jun 1, 2022

Hmm we must have missed this in the inital review in anycase we need to add the rd. prefix, support both for a while, then remove the none rd prefixed strings.

aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Jun 2, 2022
@aafeijoo-suse
fix(nvmf): deprecate old nvmf cmdline options
43fabe1 
Fixes issue dracutdevs#1831
@aafeijoo-suse aafeijoo-suse mentioned this issue Jun 2, 2022
Merged
3 tasks
johannbg pushed a commit that referenced this issue Jun 2, 2022
@aafeijoo-suse @johannbg
fix(nvmf): deprecate old nvmf cmdline options
e405501 
Fixes issue #1831
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Oct 13, 2022
@aafeijoo-suse
fix(nvmf): deprecate old nvmf cmdline options
6215ffe 
Fixes issue dracutdevs#1831

(cherry picked from commit e405501)

bsc#1203368
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Oct 13, 2022
@aafeijoo-suse
fix(nvmf): deprecate old nvmf cmdline options
e2a272d 
Fixes issue dracutdevs#1831

(cherry picked from commit e405501)

bsc#1203368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Our bugs documents Issues requiring updates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(nvmf): deprecate old nvmf cmdline options aafeijoo-suse/dracut
2 participants
@niklas88 @johannbg