Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dmsquash-live): correct regression introduced with shellcheck changes #1577

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

haraldh
Copy link
Collaborator

@haraldh haraldh commented Aug 6, 2021

"$opt" with empty opt will give errors for losetup.

#1576

Rename the variable and set the arguments dynamically, if the variable
is set.

This pull request changes...

Changes

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #1576

@haraldh haraldh requested review from danimo and johannbg as code owners August 6, 2021 13:17
@github-actions github-actions bot added dmsquash-live Issues related to the dmsquash-live module modules Issue tracker for all modules labels Aug 6, 2021
…nges

`"$opt"` with empty `opt` will give errors for `losetup`.

dracutdevs#1576

Rename the variable and set the arguments dynamically, if the variable
is set.
@haraldh haraldh changed the title fix: correct regression introduced with shellcheck changes fix(dmsquash-live): correct regression introduced with shellcheck changes Aug 6, 2021
@berlin4apk
Copy link

Can we please add a CI test for PXE boot?

@johannbg
Copy link
Collaborator

@haraldh you can just force merge your PR since @danimo has not reviewed it after all this time...

@haraldh haraldh merged commit 0c631ef into dracutdevs:master Oct 6, 2021
@haraldh haraldh deleted the losetup_options branch October 6, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dmsquash-live Issues related to the dmsquash-live module modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pxe booting a initramfs from dracut fails with "losetup: unexpected arguments"
3 participants