Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gensplash): remove module #1814

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

LaszloGombos
Copy link
Collaborator

splashutils Gentoo package (a dependency for the gensplash dracut module)
is non existent in the official Gentoo repositories.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

splashutils Gentoo package (a dependency for the gensplash dracut module)
is non existent in the official Gentoo repositories.
@github-actions github-actions bot added gensplash Issues related to the gensplash module github Issues related to .github modules Issue tracker for all modules labels May 9, 2022
@johannbg
Copy link
Collaborator

So you want to remove a module just because the component for it does not exist in Gentoo? Have you checked if the module is not being used by other distro's or if upstream is inactive?

Copy link
Collaborator

@johannbg johannbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so I've looked into it and afaikt it looks like a dead project which no one else is using.
Let's allow this to bake here for a couple of days to see if anyone objects the modules removal.

@LaszloGombos
Copy link
Collaborator Author

LaszloGombos commented May 11, 2022

Ok so I've looked into it and afaikt it looks like a dead project which no one else is using.

Thanks.

Let's allow this to bake here for a couple of days to see if anyone objects the modules removal.

Make sense.

For the benefit of other readers - https://wiki.gentoo.org/wiki/Fbsplash

@johannbg
Copy link
Collaborator

Note that splash is still supported in gentoo's gen kernel gen_configkernel, gen_initramfs, gen_determineargs
which is a bit weird since it's been deprecated in gentoo and propably trigger some errors if SPLASH="no" is not set in genkernel.conf so for whatever reason gentoo did not remove the support for it in gen kernel when the component got removed from the distro.

@johannbg
Copy link
Collaborator

@floppym note we are about to drop this module not sure if it will affect gentoo since weirdly enough genkernel still seemingly supports splash.

@floppym
Copy link
Contributor

floppym commented May 11, 2022

I'll ask around and see if Gentoo is actually using this somehow. Thanks for the heads-up.

@johannbg
Copy link
Collaborator

A week has passed and no one screamed hence merging...

@johannbg johannbg merged commit 1befc64 into dracutdevs:master May 16, 2022
@LaszloGombos LaszloGombos deleted the gensplash branch May 16, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gensplash Issues related to the gensplash module github Issues related to .github modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants