fix(dmsquash-live): use the overlay size with thin provisioning #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the overlay size in the device mapper table allows the filesystem in the base image to be extended if the overlay is larger than the base image (e.g. `resize2fs /dev/mapper/live-rw`).
gregory-lee-bartholomew
requested review from
haraldh and
johannbg
as code owners
github-actions
bot
added
modules
|
CC @FGrose |
Conan-Kudo
approved these changes
Jan 11, 2024
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
This was referenced Apr 1, 2024
|
Thanks @Conan-Kudo. I'll close this MR since the change has been merged in another MR. 🙂 |
|
I think I may have closed this prematurely. I see now that what was merged earlier was to "dracut-ng", not "dracut". I'll reopen this against "dracut" and I'll fix the commit message to be consistent with the one that was merged earlier. Sorry about the confusion. |
gregory-lee-bartholomew
changed the title
This was referenced Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the overlay size in the device mapper table allows the filesystem in the base image to be extended at runtime if the overlay is larger than the base image (i.e. this makes
resize2fs /dev/mapper/live-rwwork whenrd.live.overlay.thinis used).This pull request changes...
Changes
This patch changes the upper-bound of the
live-rwdevice when the user requests to create a thin-provisioned overlay by specifying therd.live.overlay.thinkernel parameter. The size of the overlay (typically 32GiB, but it can be specified by the user with a kernel parameter) is used rather than the size of the base image.Checklist
Fixes #
Users of Fedora Linux have been reporting this bug here: https://discussion.fedoraproject.org/t/fedora-liveos-root-system-and-available-ram/82531/1