Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zfcp_rules): correct shellcheck regression when parsing ccw args #2630

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(zfcp_rules): correct shellcheck regression when parsing ccw args #2630

merged 1 commit into from
Mar 21, 2024

Conversation

aafeijoo-suse
Copy link
Member

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes 032ecd9

@aafeijoo-suse aafeijoo-suse requested a review from tblume February 28, 2024 07:27
@github-actions github-actions bot added modules Issue tracker for all modules zfcp_rules Issues related to the zfcp_rules module labels Feb 28, 2024
Vogtinator
Vogtinator approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Vogtinator Vogtinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth checking other places whether they got similarly broken.

@aafeijoo-suse
Copy link
Member Author

Might be worth checking other places whether they got similarly broken.

I agree

@aafeijoo-suse
Copy link
Member Author

BTW this file will be removed by #2534, so I don't know if this fix makes sense upstream at this point.

@aafeijoo-suse aafeijoo-suse mentioned this pull request Feb 29, 2024
Open
3 tasks
tblume
tblume approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

johannbg
johannbg approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@johannbg johannbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johannbg johannbg merged commit 5d2bda4 into dracutdevs:master Mar 21, 2024
100 of 107 checks passed
@steffen-maier steffen-maier mentioned this pull request Mar 22, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tblume tblume tblume approved these changes

@Vogtinator Vogtinator Vogtinator approved these changes

@johannbg johannbg johannbg approved these changes

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

Assignees
No one assigned
Labels
modules Issue tracker for all modules zfcp_rules Issues related to the zfcp_rules module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aafeijoo-suse @johannbg @Vogtinator @tblume