Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card comments xml #1025

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix card comments xml #1025

wants to merge 5 commits into from

Conversation

sean-yeoh
Copy link

@sean-yeoh sean-yeoh commented May 13, 2022

Summary

Currently, card comments are exported in the XML but not in the correct node.

The exported XML looks like this, notice the individual comment's attributes are direct children inside the <comments> node, but they should be in the <comment> node instead.

image

You can see the difference by comparing it to an issue's comment.

image

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to Dradis!

Copyright assignment

Collaboration is difficult with commercial closed source but we want
to keep as much of the OSS ethos as possible available to users
who want to fix it themselves.

In order to unambiguously own and sell Dradis Framework commercial
products, we must have the copyright associated with the entire
codebase. Any code you create which is merged must be owned by us.
That's not us trying to be a jerks, that's just the way it works.

Please review the CONTRIBUTING.md
file for the details.

You can delete this section, but the following sentence needs to
remain in the PR's description:

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry

CHANGELOG Outdated
@@ -8,6 +8,7 @@
- Bugs fixes:
- [entity]:
- [future tense verb] [bug fix]
- Project export: Fix card comments not exported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Project export: Fix card comments not exported
- Project export: Fix export for comments in cards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants