Add environment options support to parsedmarc image #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- config names are translated to env var "{section}_{option}" (same case)
|
Cool idea :), thank you for bunch of good PRs. This one need to tested, I will try on some near days. P.s. reminder to myself add X security to kibana\elasic for auth and geoipupdater image for maxmind 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows configuring parsedmarc from inside the docker-compose.yml. It is written in a general way to as long as the format for the config file of parsedmarc does not change, this should continue to work, even for new configuration options.
Tested on my deployment.