chore: fix return on bad status (#3758)

dragonflydb · Sep 21, 2024 · d9f8f25 · d9f8f25
1 parent cce2eb3
commit d9f8f25
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/server/error.h b/src/server/error.h
@@ -35,11 +35,12 @@ using facade::kWrongTypeErr;
 
 #ifndef RETURN_ON_BAD_STATUS
 
-#define RETURN_ON_BAD_STATUS(x) \
-  do {                          \
-    if (!(x)) {                 \
-      return (x).status();      \
-    }                           \
+#define RETURN_ON_BAD_STATUS(x)  \
+  do {                           \
+    OpStatus __s = (x).status(); \
+    if (__s != OpStatus::OK) {   \
+      return (x).status();       \
+    }                            \
   } while (0)
 
 #endif  // RETURN_ON_BAD_STATUS