Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ToUpper calls in main_service #3947

Merged
merged 2 commits into from
Oct 18, 2024
Merged

chore: remove ToUpper calls in main_service #3947

merged 2 commits into from
Oct 18, 2024

Conversation

romange
Copy link
Collaborator

@romange romange commented Oct 18, 2024

No description provided.

@romange
chore: remove ToUpper calls in main_service
8e79223 
Also, test for IsPaused() first to avoid doing more checks for common-case.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange requested a review from kostasrim October 18, 2024 11:10
kostasrim
kostasrim reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you sed/replace all occurrences of ToUpper in one PR ? 😄

kostasrim
kostasrim previously approved these changes Oct 18, 2024
View reviewed changes
@romange romange enabled auto-merge (squash) October 18, 2024 13:37
@romange romange merged commit 84e22aa into main Oct 18, 2024
12 checks passed
@romange romange deleted the Pr4 branch October 18, 2024 14:04
romange pushed a commit that referenced this pull request Nov 11, 2024
@kostasrim @romange
fix: regression in squashing code when determining eval commands
60d46eb 
The regression was caused by #3947 and it causes crashes in bullmq.
It has not been found till now because python client sends commands in uppercase.
Fixes #4113

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange mentioned this pull request Nov 11, 2024
Merged
romange added a commit that referenced this pull request Nov 11, 2024
@romange @kostasrim
fix: regression in squashing code when determining eval commands (#4116)
fa8f3f5 
The regression was caused by #3947 and it causes crashes in bullmq.
It has not been found till now because python client sends commands in uppercase.
Fixes #4113

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Co-authored-by: Kostas Kyrimis <kostas@dragonflydb.io>
romange added a commit that referenced this pull request Nov 11, 2024
@romange @kostasrim
fix: regression in squashing code when determining eval commands (#4116)
ea85354 
The regression was caused by #3947 and it causes crashes in bullmq.
It has not been found till now because python client sends commands in uppercase.
Fixes #4113

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Co-authored-by: Kostas Kyrimis <kostas@dragonflydb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostasrim kostasrim kostasrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romange @kostasrim