[WIP] chore: add tx queue head debug info in AnalyzeTxQueue #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <kostas@dragonflydb.io>
|
@adiholden let's discuss here what else information we would like to print |
kostasrim
commented
Oct 31, 2024
| @@ -174,6 +178,9 @@ class EngineShard { | |||
|
|
|||
| // the lock fingerprint with maximum contention score. | |||
| uint64_t max_contention_lock; | |||
|
|
|||
| // We can use a vector to hold debug info for all items in the txqueue | |||
There was a problem hiding this comment.
My idea here we might want to analyze the whole txqueue, so maybe it would be interesting extending DEBUG TX to include N transactions
kostasrim
commented
Oct 31, 2024
| { | ||
| auto value = queue->At(cur); | ||
| Transaction* trx = std::get<Transaction*>(value); | ||
| info.head.debug_id_info = trx->DebugId(); |
There was a problem hiding this comment.
tx_id + name of the command + shard count. Maybe we should also include per shard data, arguments etc ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #4020