Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test hypothesis #4380

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Fix test hypothesis #4380

wants to merge 11 commits into from

Conversation

cunla
Copy link
Contributor

@cunla cunla commented Dec 28, 2024

TestServer:

  • FLUSHDB ASYNC not supported (Assuming SYNC also not supported)
  • FLUSHALL ASYNC not supported (Assuming SYNC also not supported)
    ==> Removing ASYNC parameter

TestHash:

  • HEXPIRE do not support nx/xx/gt/lt.
  • HPEXPIRE not supported.
    ==> Removed from test.

Remaining:

  • TestString
    • dragonfly raised: string exceeds maximum allowed size, fakeredis support strings up to 512 * 1024 * 1024.
  • TestList
    • dragonfly raised: One or more scores can't be converted into double

@romange
Copy link
Collaborator

romange commented Jan 7, 2025

Thank @cunla . Let's:

  1. TestServer - agree these are not important for Dragonfly (its flush operation is always asynchronous but the api call is waiting till the operation ends).
  2. HEXPIRE - agree, we do not strive for Redis 8 compatibility at this point.
  3. TestString =- yeah, we are more restrictive. have not heard much complains about it. See https://github.com/dragonflydb/dragonfly/blob/main/docs/differences.md#string-lengths-indices for more details.
  4. TestList - if I remember correctly, it happens during SORT and it's consistent with Redis/Valkey. I am looking at it again now.

@romange
Copy link
Collaborator

romange commented Jan 7, 2025

@cunla I am confirming again that the sequence:

lpush foo '\00'
sort foo

fails in sort for both Dragonfly and Redis. Seems that the problem in test?

@romange
Copy link
Collaborator

romange commented Jan 7, 2025

@cunla I fixed the crash. Please rebase 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants