chore: lock free info command with replicaof v2 #5864
+193
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
force-pushed
the
kpr2
branch
2 times, most recently
from
620f35c to
7e36655
Compare
kostasrim
commented
Sep 28, 2025
| } | ||
| } | ||
|
|
||
| void ServerFamily::RoleV2(CmdArgList args, const CommandContext& cmd_cntx) { |
There was a problem hiding this comment.
Once the regression tests run for some time we will slowly remove Role() and ReplicaOf etc (all the variants of the previous versions)
kostasrim
force-pushed
the
kpr2
branch
2 times, most recently
from
7cee991 to
59b3350
Compare
Signed-off-by: kostas <kostas@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5774, this PR removes locking the
replica_of_mu_from info command and uses the thread locals && replica of v2 algorithm.No more locking and blocking for INFO command during
replicaofortakeover🥳 🎉 🌮