Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change edit cluster #388

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: change edit cluster #388

merged 1 commit into from
Sep 10, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <1186037180@qq.com>
@Liam-Zhao Liam-Zhao requested a review from gaius-qi September 10, 2024 08:09
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner September 10, 2024 08:09
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 10300ba into main Sep 10, 2024
8 checks passed
@gaius-qi gaius-qi deleted the feat--change-edit-cluster branch September 10, 2024 09:02
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (c4fbb7a) to head (1e3a682).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          30       30           
  Lines        3173     3173           
  Branches      935      935           
=======================================
  Hits         3118     3118           
  Misses         52       52           
  Partials        3        3           
Files with missing lines Coverage Δ
src/components/clusters/edit.tsx 99.52% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants