Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preheat page switching state to initiate multiple requests #392

Merged

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Sep 12, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <1186037180@qq.com>
@Liam-Zhao Liam-Zhao added the bug Something isn't working label Sep 12, 2024
@Liam-Zhao Liam-Zhao requested a review from gaius-qi September 12, 2024 10:40
@Liam-Zhao Liam-Zhao self-assigned this Sep 12, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner September 12, 2024 10:40
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (402e683) to head (bf2ad96).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   98.14%   98.17%   +0.02%     
==========================================
  Files          31       31              
  Lines        3287     3284       -3     
  Branches      989      986       -3     
==========================================
- Hits         3226     3224       -2     
+ Misses         59       58       -1     
  Partials        2        2              
Files with missing lines Coverage Δ
src/components/job/preheats/index.tsx 98.94% <100.00%> (-0.02%) ⬇️
src/lib/api.ts 94.21% <100.00%> (+0.46%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit feda25f into main Sep 12, 2024
8 checks passed
@gaius-qi gaius-qi deleted the fix--preheat-page-switching-state-to-initiate-multiple-requests branch September 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants