Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix page bugs #428

Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat: Fix page bugs #428

merged 1 commit into from
Dec 27, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Dec 27, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <1186037180@qq.com>
@Liam-Zhao Liam-Zhao requested a review from gaius-qi December 27, 2024 09:50
@Liam-Zhao Liam-Zhao self-assigned this Dec 27, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner December 27, 2024 09:50
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 99.23077% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.10%. Comparing base (21db335) to head (bfb88d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/menu/index.tsx 96.55% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   98.03%   98.10%   +0.06%     
==========================================
  Files          39       39              
  Lines        4279     4275       -4     
  Branches     1367     1369       +2     
==========================================
- Hits         4195     4194       -1     
+ Misses         73       71       -2     
+ Partials       11       10       -1     
Files with missing lines Coverage Δ
src/components/clusters/peers/index.tsx 98.07% <ø> (ø)
src/components/clusters/schedulers/index.tsx 98.19% <100.00%> (ø)
src/components/clusters/seed-peers/index.tsx 98.97% <100.00%> (-0.02%) ⬇️
src/components/job/preheats/new.tsx 99.43% <100.00%> (ø)
src/components/job/preheats/show.tsx 99.08% <100.00%> (+0.93%) ⬆️
src/components/job/task/index.tsx 100.00% <100.00%> (ø)
src/components/users/index.tsx 97.75% <100.00%> (+1.04%) ⬆️
src/components/menu/index.tsx 97.14% <96.55%> (+0.02%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit dde2699 into main Dec 27, 2024
8 checks passed
@gaius-qi gaius-qi deleted the feat--Fix-page-bugs branch December 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants