Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update grpc listen address on scheduler and cdn #1205

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Update grpc listen address on scheduler and cdn.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 29, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 29, 2022 07:09
@gaius-qi gaius-qi self-assigned this Mar 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #1205 (e1c7aff) into main (b726ad1) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   46.45%   46.02%   -0.43%     
==========================================
  Files         133      133              
  Lines       10523    10528       +5     
==========================================
- Hits         4888     4846      -42     
- Misses       5081     5137      +56     
+ Partials      554      545       -9     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.02% <0.00%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdn/rpcserver/config.go 0.00% <0.00%> (ø)
cdn/rpcserver/rpcserver.go 60.60% <0.00%> (ø)
scheduler/config/config.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_piecetask_poller.go 30.37% <0.00%> (-22.97%) ⬇️
client/daemon/peer/peertask_conductor.go 56.47% <0.00%> (-1.22%) ⬇️

yxxhero
yxxhero previously approved these changes Mar 29, 2022
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

@qwtsc qwtsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 5e8daa9 into main Mar 29, 2022
@gaius-qi gaius-qi deleted the feature/listen branch March 29, 2022 08:18
gaius-qi added a commit to gaius-qi/Dragonfly2 that referenced this pull request Mar 29, 2022
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants