-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: support syncpeers by service and optimize the merge logic #3637
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3637 +/- ##
==========================================
+ Coverage 35.41% 35.46% +0.04%
==========================================
Files 335 336 +1
Lines 37531 37657 +126
==========================================
+ Hits 13293 13355 +62
- Misses 23409 23471 +62
- Partials 829 831 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9257548
to
449b690
Compare
Signed-off-by: cormick <cormick1080@gmail.com>
449b690
to
2a5f8ba
Compare
5106e76
to
2b4a44c
Compare
2b4a44c
to
cf23b06
Compare
cf23b06
to
c2a6c20
Compare
Signed-off-by: cormick <cormick1080@gmail.com>
c2a6c20
to
74ea568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove lo
library and define the func in pkg/container/map/map.go
.
fe785e0
to
585632f
Compare
585632f
to
24f9ef0
Compare
Signed-off-by: cormick <cormick1080@gmail.com>
24f9ef0
to
a9a2ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
still in progress
Related Issue
#3634