nydusify: fix error in go vet

`sudo` in action will change go env, remove sudo.
In runner user, we can create file in unpacktargz-test inseted of temp/unpacktargz-test,
so don't use os.CreateTemp in archive_test.go.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>

.github/workflows/smoke.yml

@@ -193,7 +193,7 @@ jobs:
     - name: Unit Test
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/bin v1.54.2
-        sudo make -e DOCKER=false contrib-test
+        make -e DOCKER=false contrib-test
     - name: Upload contrib coverage file
       uses: actions/upload-artifact@v3
       with:

contrib/nydusify/Makefile

@@ -36,4 +36,4 @@ coverage: test
 
 clean:
 	rm -f cmd/nydusify
-	rm -f coverage.out
+	rm -f coverage.txt

contrib/nydusify/pkg/utils/archive_test.go

@@ -31,10 +31,12 @@ func TestPackTargzInfo(t *testing.T) {
 }
 
 func TestUnpackTargz(t *testing.T) {
-	file, err := os.CreateTemp("", "nydusify-test")
-	defer os.RemoveAll(file.Name())
+	err := os.MkdirAll("unpacktargz-test", 0777)
+	defer os.RemoveAll("unpacktargz-test")
+	require.NoError(t, err)
+	file, err := os.Create("unpacktargz-test/test-file")
 	require.NoError(t, err)
-	err = os.WriteFile(file.Name(), []byte("123456789"), 0666)
+	err = os.WriteFile(file.Name(), []byte("123456789"), 0777)
 	require.NoError(t, err)
 	reader, err := PackTargz(file.Name(), file.Name(), true)
 	require.NoError(t, err)