Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Compare the current benchmark tests with the master branch's. #1221

Closed
Desiki-high opened this issue Apr 17, 2023 · 2 comments · Fixed by #1244
Closed

Proposal: Compare the current benchmark tests with the master branch's. #1221

Desiki-high opened this issue Apr 17, 2023 · 2 comments · Fixed by #1244
Assignees
@Desiki-high
Labels
performance

Comments

@Desiki-high
Copy link
Member

Reference: #1219 (comment).

We need to compare the benchmark tests between the PR and the master branch's.
@Desiki-high Desiki-high self-assigned this Apr 20, 2023
@adamqqqplay
Copy link
Member

@Desiki-high Hi, Thanks for your work, the benchmarks are now working.

I have a small suggestion, can you let github-actions bot modify the previous comments instead of re-comments after each test. In this way, the comment page of the PR can be made clearer.

@Desiki-high
Copy link
Member Author

@Desiki-high Hi, Thanks for your work, the benchmarks are now working.

I have a small suggestion, can you let github-actions bot modify the previous comments instead of re-comments after each test. In this way, the comment page of the PR can be made clearer.

Got it. Thanks for your good idea.

This was referenced Apr 20, 2023
Closed
Merged
@Desiki-high Desiki-high linked a pull request Apr 23, 2023 that will close this issue
feat: compare benchmark between PR and master #1244
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Desiki-high Desiki-high

Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: compare benchmark between PR and master Desiki-high/nydus
2 participants
@adamqqqplay @Desiki-high