-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compare benchmark between PR and master #1244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
- Coverage 45.03% 45.01% -0.03%
==========================================
Files 126 126
Lines 37382 37382
Branches 37382 37382
==========================================
- Hits 16836 16827 -9
- Misses 19659 19668 +9
Partials 887 887 |
2067d1a
to
37e69db
Compare
0ad1e4c
to
2440bd0
Compare
063bd21
to
d6c9233
Compare
1. refactor. 2. add the arg mode to adapt two benchmark summary modes. Signed-off-by: Desiki-high <ding_yadong@foxmail.com>
1ecd822
to
8b6f47a
Compare
b0ac69d
to
f1aac18
Compare
compare the benchmark result between PR and master when smoke test triggered by pull request Signed-off-by: Desiki-high <ding_yadong@foxmail.com>
5c80376
to
657023c
Compare
Signed-off-by: Desiki-high <ding_yadong@foxmail.com>
657023c
to
b12a3d9
Compare
@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69835 |
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69851 |
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should compare the benchmark between PR and master. Ref: #1221.
1. Refator the benchmark summary.
To add more features in benchmark summary, bash is difficult to dev. So we use python to refactor.
2. Add arg mode for the benchmark_summary.py.
Adaptate different benchmark summmarys for push, schedule and pull_request triggered events. We only need to compare the benchmark in pull request event.
3. Add image-size in benchmark.
Calculate the sum of each layers(nydus blob) size in manifest.
4. Add the benchmark-compare jobs in smoke test.
benchmark summary on pull_request
benchmark summary on push or schedule