Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nydusify: append fs version annotation in image manifest #496

Closed
imeoer opened this issue Jun 15, 2022 · 1 comment · Fixed by #497
Closed

nydusify: append fs version annotation in image manifest #496

imeoer opened this issue Jun 15, 2022 · 1 comment · Fixed by #497

Comments

@imeoer
Copy link
Collaborator

imeoer commented Jun 15, 2022

We need to add an annotation to the image manifest for detecting the bootstrap fs version without reading the magic number from bootstrap, example:

"containerd.io/snapshot/nydus-bootstrap": "true",
"containerd.io/snapshot/nydus-fs-version": "6",
...
@hsiangkao
Copy link
Contributor

I tend to leave this optional, both ways are ok to us.

yawqi added a commit to yawqi/image-service that referenced this issue Jun 15, 2022
@yawqi
nydusify: add fs-version annotation
3414dc8 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
yawqi added a commit to yawqi/image-service that referenced this issue Jun 15, 2022
@yawqi
nydusify: add fs-version annotation
9dea913 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
@yawqi yawqi mentioned this issue Jun 15, 2022
Merged
yawqi added a commit to yawqi/image-service that referenced this issue Jun 15, 2022
@yawqi
nydusify: add fs-version annotation
167e336 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
yawqi added a commit to yawqi/image-service that referenced this issue Jun 15, 2022
@yawqi
nydusify: add fs-version annotation
ae23437 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
yawqi added a commit to yawqi/image-service that referenced this issue Jun 15, 2022
@yawqi
nydusify: add fs-version annotation
8a7c54a 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
yawqi added a commit to yawqi/image-service that referenced this issue Jun 16, 2022
@yawqi
nydusify: add fs-version annotation
96f4878 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
yawqi added a commit to yawqi/image-service that referenced this issue Jun 16, 2022
@yawqi
nydusify: add fs-version annotation
1999069 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
yawqi added a commit to yawqi/image-service that referenced this issue Jun 17, 2022
@yawqi
nydusify: add fs-version annotation
35f5903 
Add an annotation to the image manifest for detecting the bootstrap fs
version without reading the magic number from bootstrap.

fix dragonflyoss#496

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nydusify: add fs-version annotation yawqi/image-service
2 participants
@imeoer @hsiangkao