nydus-test: fix debug panic #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduction: add `NYDUS_TEST_VERBOSE=YES` to booting params of pytest.
For example:
```shell
sudo NYDUS_TEST_VERBOSE=YES pytest functional-test/test_layered_image.py::test_basic_read
```
Output:
```
ERROR root:workload_gen.py:459 Stress read failure, not all arguments converted during string formatting
Traceback (most recent call last):
File "/home/morgan/workspace/rust/image-service/contrib/nydus-test/framework/workload_gen.py", line 456, in io_read
cnt, size, duration = self.read_collected_files(io_duration)
File "/home/morgan/workspace/rust/image-service/contrib/nydus-test/framework/workload_gen.py", line 404, in read_collected_files
logging.debug(
File "/usr/lib/python3.10/logging/__init__.py", line 2148, in debug
root.debug(msg, *args, **kwargs)
File "/usr/lib/python3.10/logging/__init__.py", line 1465, in debug
self._log(DEBUG, msg, args, **kwargs)
File "/usr/lib/python3.10/logging/__init__.py", line 1624, in _log
self.handle(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1634, in handle
self.callHandlers(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1696, in callHandlers
hdlr.handle(record)
File "/usr/lib/python3.10/logging/__init__.py", line 968, in handle
self.emit(record)
File "/usr/local/lib/python3.10/dist-packages/_pytest/logging.py", line 343, in emit
super().emit(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1108, in emit
self.handleError(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1100, in emit
msg = self.format(record)
File "/usr/lib/python3.10/logging/__init__.py", line 943, in format
return fmt.format(record)
File "/usr/local/lib/python3.10/dist-packages/_pytest/logging.py", line 114, in format
return super().format(record)
File "/usr/lib/python3.10/logging/__init__.py", line 678, in format
record.message = record.getMessage()
File "/usr/lib/python3.10/logging/__init__.py", line 368, in getMessage
msg = msg % self.args
TypeError: not all arguments converted during string formatting
```
Signed-off-by: 泰友 <cuichengxu.ccx@antgroup.com>
ccx1024cc
requested review from
liubin,
jiangliu and
luodw
and removed request for
a team
|
@ccx1024cc , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/48570 |
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
|||||||||||||||||||||
imeoer
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction: add
NYDUS_TEST_VERBOSE=YESto booting envs of pytest.For example:
Output:
Signed-off-by: 泰友 cuichengxu.ccx@antgroup.com