service: improve the resuability of create_daemon #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to improve the reusability of the function create_daemon the parameter processing logic is moved from the create_daemon and initialize_fscache_service functions to the upper layer function process_singleton_arguments Signed-off-by: taohong <taoohong@linux.alibaba.com>
taoohong
requested review from
bergwolf,
liubin and
liubogithub
and removed request for
a team
|
@taoohong , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/52259 |
Signed-off-by: taohong <taoohong@linux.alibaba.com>
|
@taoohong , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/52272 |
|
@taoohong , The CI test is completed, please check result:
Congratulations, your test job passed! |
|||||||||||||||||||||
|
@taoohong , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/52421 |
|
@taoohong , The CI test is completed, please check result:
Congratulations, your test job passed! |
|||||||||||||||||||||
jiangliu
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve the reusability of the function create_daemon, the parameter processing logic is moved from the create_daemon and initialize_fscache_service functions to the upper layer function process_singleton_arguments