-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine builder and rafs to prepare for tarfs #1144
Conversation
Rename EROFS_BLOCK_SIZE to EROFS_BLOCK_SIZE_4096, we are going to support EROFS_BLOCK_SIZE_512. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55499 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55514 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55520 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55657 |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55880 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55899 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
Replace with_context() by context() when possible to avoid function call. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55948 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
rafs/src/builder/tarball.rs
Outdated
match self.path_inode_map.get(parent_path) { | ||
Some((i, idx)) => { | ||
if !nodes[*idx].is_dir() { | ||
panic!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use bail!
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point:) Fixed
Only invoke v5 related code for v5 builds, also enforce strictly validation when creating missing directory for tar based builds. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/55994 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
Refine builder and rafs to prepare for tarfs.