Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafs: optimize Node::name() to reduce image build time #1222

Merged
merged 1 commit into from
Apr 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rafs/src/builder/core/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,9 @@ impl Node {

/// Get filename of the inode.
pub fn name(&self) -> &OsStr {
if self.path() == &self.info.source {
if let Some(name) = self.target_vec().last() {
name
} else if self.path() == &self.info.source {
OsStr::from_bytes(ROOT_PATH_NAME)
} else {
// Safe to unwrap because `path` is returned from `path()` which is canonicalized
Expand Down