-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nydusify: add some unit tests and add test coverage output #1246
Conversation
@adamqqqplay , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69614 |
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 45.06% 45.05% -0.01%
==========================================
Files 126 126
Lines 37395 37395
Branches 37395 37395
==========================================
- Hits 16851 16850 -1
- Misses 19656 19657 +1
Partials 888 888 |
9cc9696
to
89bd761
Compare
@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69618 |
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
89bd761
to
fba51c9
Compare
@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69769 |
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69953 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
"strings" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use github.com/stretchr/testify/require
to stop the test once the error happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, your suggestion is very useful.
1. Introduce `make coverage` to print coverage in console. Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
9c5d201
to
05eb795
Compare
@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/70270 |
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
Introduce
make coverage
to print coverage in console.