Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: support nydus-overlayfs and ctr-remote on different platforms #1256

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

mofishzz
Copy link
Collaborator

@mofishzz mofishzz commented Apr 28, 2023

Otherwise, the binary we compiled cannot run on other platforms such as arm.

Fix: #401 #407

Otherwise, the binary we compiled cannot run on other platforms such as
arm.

Signed-off-by: Huang Jianan <jnhuang@linux.alibaba.com>
@mofishzz mofishzz requested a review from a team as a code owner April 28, 2023 08:37
@mofishzz mofishzz requested review from liubin, liubogithub and hsiangkao and removed request for a team April 28, 2023 08:37
@anolis-bot
Copy link
Collaborator

@mofishzz , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/70364

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #1256 (6e397e8) into master (a78db8b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
+ Coverage   45.04%   45.07%   +0.02%     
==========================================
  Files         126      126              
  Lines       37382    37395      +13     
  Branches    37382    37395      +13     
==========================================
+ Hits        16838    16855      +17     
+ Misses      19659    19649      -10     
- Partials      885      891       +6     

see 4 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@mofishzz , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@adamqqqplay adamqqqplay self-requested a review April 28, 2023 09:32
Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anolis-bot
Copy link
Collaborator

@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/70380

@imeoer imeoer merged commit 8743e81 into dragonflyoss:master Apr 28, 2023
@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@mofishzz mofishzz deleted the hjn/fix-arm-compile branch May 29, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add arm support for CI and release
4 participants