Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings in Release and Integration Test #1264

Merged
merged 2 commits into from
May 8, 2023

Conversation

Desiki-high
Copy link
Member

Update actions version

  1. Since we update the rust cache version in release from v1 to v2.2.0 in Reuse the rust caches #1260 , the target-dir is useless, and the ./target will be cached default.
  2. We should update the actions to use Node.js 16: actions/checkout@v2, actions/setup-go@v2, actions/cache@v2, actions/upload-artifact@v2.

changelogs

  1. https://github.com/Swatinem/rust-cache/releases/tag/v2.0.0
  2. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Ref: warnings in https://github.com/dragonflyoss/image-service/actions/runs/4903861322

Since we update the rust cache version from v1 to v2.2.0, the target-dir
is useless, and the ./target will be cached default.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested a review from a team as a code owner May 7, 2023 03:43
@Desiki-high Desiki-high requested review from bergwolf, imeoer and hsiangkao and removed request for a team May 7, 2023 03:43
@anolis-bot
Copy link
Collaborator

@Desiki-high , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71455

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #1264 (672e523) into master (c2637ee) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
- Coverage   45.07%   45.05%   -0.02%     
==========================================
  Files         126      126              
  Lines       37395    37395              
  Branches    37395    37395              
==========================================
- Hits        16856    16850       -6     
- Misses      19648    19656       +8     
+ Partials      891      889       -2     

see 3 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 2f743c8 into dragonflyoss:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants