Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): add macos arm64 artifact #1293

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

killagu
Copy link
Contributor

@killagu killagu commented May 20, 2023

Relevant Issue (if applicable)

Details

Add macos arm64 artifact to github release.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

No test need.

@killagu killagu requested a review from a team as a code owner May 20, 2023 02:42
@killagu killagu requested review from liubin, imeoer and jiangliu and removed request for a team May 20, 2023 02:42
@anolis-bot
Copy link
Collaborator

@killagu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74298

@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74299

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #1293 (64963cc) into master (809f8d9) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 64963cc differs from pull request most recent head 6eef1ac. Consider uploading reports for the commit 6eef1ac to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
- Coverage   46.06%   46.03%   -0.03%     
==========================================
  Files         124      124              
  Lines       36934    36934              
  Branches    36934    36934              
==========================================
- Hits        17012    17003       -9     
- Misses      19033    19042       +9     
  Partials      889      889              

see 4 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we package the binary in the contrib directory, such as Nydusify, into macos?

@imeoer
Copy link
Collaborator

imeoer commented May 23, 2023

Can we package the binary in the contrib directory, such as Nydusify, into macos?

@adamqqqplay nydusify and all components in contrib do not support macos yet.

@killagu killagu requested a review from a team as a code owner May 23, 2023 03:05
@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74685

@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74688

@adamqqqplay
Copy link
Member

Can we package the binary in the contrib directory, such as Nydusify, into macos?

@adamqqqplay nydusify and all components in contrib do not support macos yet.

@imeoer Ok, I thought it was just not packaged for release

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74734

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74738

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74745

Signed-off-by: killagu <killa123@126.com>
@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74746

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@imeoer
Copy link
Collaborator

imeoer commented May 24, 2023

Hi @killagu, have any successful example links for the release job?

@killagu
Copy link
Contributor Author

killagu commented Jun 1, 2023

@imeoer imeoer merged commit b4c76cf into dragonflyoss:master Jun 12, 2023
@killagu
Copy link
Contributor Author

killagu commented Jun 12, 2023

Sorry, we should wait fuse-backend-rs release new version 😅.

For now build on macos with m1 is still failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants