builder: set the default compression algorithm for meta ci to lz4 #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofishzz
requested review from
liubogithub,
changweige and
adamqqqplay
and removed request for
a team
|
@mofishzz , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/76723 |
error[vulnerability]: Resource exhaustion vulnerability in h2 may lead to Denial of Service (DoS) ┌─ /github/workspace/Cargo.lock:68:1 │ 68 │ h2 0.3.13 registry+https://github.com/rust-lang/crates.io-index │ --------------------------------------------------------------- security vulnerability detected │ = ID: RUSTSEC-2023-0034 = Advisory: https://rustsec.org/advisories/RUSTSEC-2023-0034 = If an attacker is able to flood the network with pairs of `HEADERS`/`RST_STREAM` frames, such that the `h2` application is not able to accept them faster than the bytes are received, the pending accept queue can grow in memory usage. Being able to do this consistently can result in excessive memory use, and eventually trigger Out Of Memory. This flaw is corrected in [hyperium/h2#668](hyperium/h2#668), which restricts remote reset stream count by default. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
We set the compression algorithm of meta ci to zstd by default, but there is no option for nydus-image to configure it. This could cause compatibility problems on the nydus version that does not support zstd. Let's reset it to lz4 by default. Signed-off-by: Huang Jianan <jnhuang95@gmail.com>
|
@mofishzz , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/76728 |
|
@mofishzz , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@mofishzz , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set the compression algorithm of meta ci to zstd by default, but there is no option for nydus-image to configure it.
This could cause compatibility problems on the nydus version that does not support zstd. Let's reset it to lz4 by default.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.