Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add containerd runtime-level snapshotter usage for nydus #1353

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

Iamleos
Copy link

@Iamleos Iamleos commented Jul 6, 2023

Relevant Issue (if applicable)

#1296

Details

Containerd (version >= 1.7.0) has supported runtime-level snapshotter. Developers can using different snapshotter with different runtime in the same environment. I think this feature is very important and necessary for Nydus that is used in production environment. The brief content of this PR is about how to use runtime-level snapshotter.

cc @adamqqqplay @zyfjeff

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: kangkexi <kangkexi@megvii.com>
@Iamleos Iamleos requested a review from a team as a code owner July 6, 2023 08:21
@Iamleos Iamleos requested review from liubogithub, imeoer and hsiangkao and removed request for a team July 6, 2023 08:21
@anolis-bot
Copy link
Collaborator

@Iamleos , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83168

@Iamleos
Copy link
Author

Iamleos commented Jul 6, 2023

@imeoer @liubogithub @hsiangkao

@anolis-bot
Copy link
Collaborator

@Iamleos , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@adamqqqplay adamqqqplay linked an issue Jul 6, 2023 that may be closed by this pull request
@anolis-bot
Copy link
Collaborator

@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83215

@anolis-bot
Copy link
Collaborator

@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83216

@anolis-bot
Copy link
Collaborator

@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83217

@anolis-bot
Copy link
Collaborator

@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83218

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

docs/containerd-env-setup.md Outdated Show resolved Hide resolved
docs/containerd-env-setup.md Outdated Show resolved Hide resolved
docs/containerd-env-setup.md Outdated Show resolved Hide resolved
Signed-off-by: kangkexi <kangkexi@megvii.com>
@anolis-bot
Copy link
Collaborator

@Iamleos , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83298

@anolis-bot
Copy link
Collaborator

@Iamleos , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux❌ FAIL

Sorry, your test job failed. Please get the details in the link.

docs/containerd-env-setup.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM, thanks!

@yqleng1987
Copy link
Contributor

/retest

@anolis-bot
Copy link
Collaborator

@yqleng1987 , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83306

@anolis-bot
Copy link
Collaborator

@yqleng1987 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@lostjeffle
Copy link

/retest

@anolis-bot
Copy link
Collaborator

@lostjeffle , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83309

@anolis-bot
Copy link
Collaborator

@lostjeffle , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

Signed-off-by: kangkexi <kangkexi@megvii.com>
@anolis-bot
Copy link
Collaborator

@Iamleos , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83329

@imeoer imeoer merged commit ba3c8fa into dragonflyoss:master Jul 7, 2023
@anolis-bot
Copy link
Collaborator

@Iamleos , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add doc for runtime-level snapshotter usage
6 participants