U2.2 backport - #1229 #1311 # 1348 #1368
Conversation
ccx1024cc
requested review from
liubin,
luodw and
adamqqqplay
and removed request for
a team
|
@ccx1024cc , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84163 |
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Including:
* regular file with chinese name
* regular with long name
* symbolic link of deleted file
* large regular file of 13MB
* regular file with hole at both head and tail
* empty regular file
Signed-off-by: 泰友 <cuichengxu.ccx@antgroup.com>
Files larger than 4G leads to prefetch panic, because the max blob io range is smaller than 4G. This pr changes blob io max size from u32 to u64. Signed-off-by: 泰友 <cuichengxu.ccx@antgroup.com>
|
@ccx1024cc , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84165 |
|
@ccx1024cc , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84166 |
|
@ccx1024cc , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84167 |
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
* fix: amplify io is too large to hold in fuse buffer
Fuse request buffer is fixed by `FUSE_KERN_BUF_SIZE * pagesize() + FUSE_HEADER_ SIZE`. When amplify io is larger than it, FuseDevWriter suffers from smaller buffer. As a result, invalid data error is returned.
Reproduction:
run nydusd with 3MB amplify_io
error from random io:
reply error header OutHeader { len: 16, error: -5, unique: 108 }, error Custom { kind: InvalidData, error: "data out of range, available 1052656 requested 1250066" }
Details:
size of fuse buffer = 1052656 + 16 (size of inner header) = 256(page number) * 4096(page size) + 4096(fuse header)
let amplify_io = min(user_specified, fuseWriter.available_bytes())
Resolution:
This pr is not best implements, but independent of modification to [fuse-backend-rs]("https://github.com/cloud-hypervisor/fuse-backend-rs").
In future, evalucation of amplify_io will be replaced with [ZeroCopyWriter.available_bytes()]("cloud-hypervisor/fuse-backend-rs#135").
Signed-off-by: 泰友 <cuichengxu.ccx@antgroup.com>
* feat: e2e for amplify io larger than fuse buffer
Signed-off-by: 泰友 <cuichengxu.ccx@antgroup.com>
---------
Signed-off-by: 泰友 <cuichengxu.ccx@antgroup.com>
Co-authored-by: 泰友 <cuichengxu.ccx@antgroup.com>
|
@ccx1024cc , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84176 |
|
@ccx1024cc , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84178 |
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@ccx1024cc , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84218 |
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
These bugfix is important. Can we backport it to v2.1.0 as well? |
Maybe 2.2 is a better choice. It's a LTS. |
Backport
feat: add more types of file to smoke #1229
fix: amplify io is too large to hold in fuse buffer #1311
fix: large files broke prefetch #1348