-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nydusify: support --with-referrer option #1384
Conversation
@imeoer , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87910 |
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87913 |
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
- Coverage 46.32% 46.31% -0.01%
==========================================
Files 122 122
Lines 38071 38071
Branches 38071 38071
==========================================
- Hits 17635 17632 -3
- Misses 19512 19513 +1
- Partials 924 926 +2 |
Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
With this option, we can track all nydus images associated with an OCI image. For example, in Harbor we can cascade to show nydus images linked to an OCI image, deleting the OCI image can also delete the corresponding nydus images. At runtime, nydus snapshotter can also automatically upgrade an OCI image run to nydus image. Prior to this PR, we had enabled this feature by default. However, it is now known that Docker Hub does not yet support Referrer. Therefore, adding this option to disable this feature by default, to ensure broad compatibility with various image registries. Fix dragonflyoss#1363. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
c040c7d
to
500b904
Compare
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87927 |
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
Relevant Issue (if applicable)
#1363
Details
With this option, we can track all nydus images associated with
an OCI image. For example, in Harbor we can cascade to show nydus
images linked to an OCI image, deleting the OCI image can also delete
the corresponding nydus images. At runtime, nydus snapshotter can also
automatically upgrade an OCI image run to nydus image.
Prior to this PR, we had enabled this feature by default. However,
it is now known that Docker Hub does not yet support Referrer.
Therefore, adding this option to disable this feature by default,
to ensure broad compatibility with various image registries.
Fix #1363.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.