-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: remove useless test files #1450
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
==========================================
- Coverage 46.34% 44.37% -1.97%
==========================================
Files 123 123
Lines 38896 38896
Branches 38896 38896
==========================================
- Hits 18026 17261 -765
- Misses 19898 20695 +797
+ Partials 972 940 -32 |
The code coverage is down by |
Currently, we only count unit test coverage in this project. |
@bergwolf This may be due to the codecov CI tests failing for a period of time. (The repository name has been changed to nydus.) —— from @adamqqqplay |
The python integration test is too long without maintenance, it should be replaced with the go integration test in smoke/tests. Signed-off-by: Yan Song <yansong.ys@antgroup.com>
The rust integration test has been replaced with the go integration test in smoke/tests, let's remove it. Signed-off-by: Yan Song <yansong.ys@antgroup.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Since dragonflyoss#1450, we have remove the Integration Test. The files in `tests` directory is useless. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.