Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go work: support go workspace mode and sync deps #1464

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Nov 2, 2023

We have multiple Golang modules in the repo and Golang has supported the workspaces, see https://go.dev/blog/get-familiar-with-workspaces. I think go work can help to develop this repo in the future.

Details

  1. Use go work to manage multiple Golang modules.
  2. Use go work sync to synchronize versions of the same dependencies for different modules.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner November 2, 2023 02:57
@Desiki-high Desiki-high requested review from bergwolf, liubin and adamqqqplay and removed request for a team November 2, 2023 02:57
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1464 (d27f12e) into master (ace7c36) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
- Coverage   44.37%   44.37%   -0.01%     
==========================================
  Files         123      123              
  Lines       38896    38896              
  Branches    38896    38896              
==========================================
- Hits        17261    17259       -2     
- Misses      20695    20696       +1     
- Partials      940      941       +1     

see 3 files with indirect coverage changes

@Desiki-high Desiki-high changed the title go work: support go workspace mode adn sync deps go work: support go workspace mode and sync deps Nov 2, 2023
We have mutile golang modules in repo, golang had supported the workspaces,
see https://go.dev/blog/get-familiar-with-workspaces.
Use `go work sync` to synchronize versions of the same dependencies for different modules.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@Desiki-high
Copy link
Member Author

cc @imeoer and @ccx1024cc, PTAL.

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jiangliu jiangliu merged commit 4d4ebe6 into dragonflyoss:master Nov 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants