Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up build on macos #1477

Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix up build on macos #1477

merged 3 commits into from
Nov 9, 2023

Conversation

bergwolf
Copy link
Member

@bergwolf bergwolf commented Nov 9, 2023

fix failures in https://github.com/dragonflyoss/nydus/actions/runs/6804602738, and add smoke test to validate macos build.

@bergwolf bergwolf requested review from a team as code owners November 9, 2023 02:35
@bergwolf bergwolf requested review from liubin, liubogithub and gaius-qi and removed request for a team November 9, 2023 02:35
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1477 (20f803e) into master (b572a0f) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1477   +/-   ##
=======================================
  Coverage   62.49%   62.49%           
=======================================
  Files         123      123           
  Lines       43132    43131    -1     
  Branches    43132    43131    -1     
=======================================
  Hits        26955    26955           
+ Misses      14869    14868    -1     
  Partials     1308     1308           
Files Coverage Δ
builder/src/core/overlay.rs 92.38% <100.00%> (ø)
rafs/src/metadata/layout/v6.rs 85.19% <100.00%> (ø)
rafs/src/mock/mock_inode.rs 87.59% <100.00%> (ø)
service/src/singleton.rs 55.11% <ø> (-0.15%) ⬇️
utils/src/compact.rs 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Signed-off-by: Peng Tao <bergwolf@gmail.com>
We are only testing blob cache and fscache in unit tests. And we are
testing linux device id. All of them do not work on macos at all.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
These are u16 on macos.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@jiangliu jiangliu merged commit 46dca17 into dragonflyoss:master Nov 9, 2023
26 checks passed
@bergwolf bergwolf deleted the github/macos branch November 9, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants