-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nydusify: upgrade containerd package #1512
nydusify: upgrade containerd package #1512
Conversation
To import some fixups from containerd/containerd#9405. Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Why not base on the latest version of |
We depend on the unmerged PR containerd/containerd#9405 |
So what is different between https://github.com/nydusaccelerator/containerd/tree/remotes-push-in-chunked and https://github.com/nydusaccelerator/containerd/tree/remotes-push-in-chunked-v1, you want to rebase to containerd/containerd@4f03e10? |
I notice containerd/containerd#9405 is from nydusaccelerator:remotes-push-in-chunked. |
Thanks for the careful review, the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1512 +/- ##
==========================================
- Coverage 62.74% 62.73% -0.01%
==========================================
Files 129 129
Lines 44158 44158
Branches 44158 44158
==========================================
- Hits 27705 27702 -3
Misses 15088 15088
- Partials 1365 1368 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To import some fixups from containerd/containerd#9405.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.