Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint version and use it in smoke module #1521

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

N/A.

Details

  1. upgrade golangci-lint to v1.54.2 and fix some errors found by golangci-lint.
  2. use golangci-lint in smoke module.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

We have some golang lint error in nydusify.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested review from a team as code owners December 14, 2023 08:23
@Desiki-high Desiki-high requested review from bergwolf, jiangliu and hsiangkao and removed request for a team December 14, 2023 08:23
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #1521 (14bf711) into master (194641a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
- Coverage   62.73%   62.72%   -0.02%     
==========================================
  Files         129      129              
  Lines       44158    44158              
  Branches    44158    44158              
==========================================
- Hits        27703    27698       -5     
- Misses      15088    15092       +4     
- Partials     1367     1368       +1     

see 2 files with indirect coverage changes

@Desiki-high Desiki-high changed the title Upgreade golangci-lint version and use it in smoke module Upgrade golangci-lint version and use it in smoke module Dec 14, 2023
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit 2bca6f2 into dragonflyoss:master Dec 15, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants