Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats test: change rust docker image to Debian 11 bullseye version #1535

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

time="2024-01-02T08:35:55.227978686+08:00" level=info msg="Start nydus-snapshotter. Version: v0.13.1-43-g47d4311, PID: 3816076, FsDriver: fscache, DaemonMode: shared"
time="2024-01-02T08:35:55.251926930+08:00" level=info msg="Trying to translate bucket records..."
time="2024-01-02T08:35:55.251964327+08:00" level=info msg="Trying to update bucket records from v1.0 to v1.1 ..."
time="2024-01-02T08:35:55.254677837+08:00" level=info msg="Run daemons monitor..."
time="2024-01-02T08:35:55.254810535+08:00" level=info msg="initializing shared nydus daemon for fscache"
time="2024-01-02T08:35:55.255910957+08:00" level=info msg="nydusd command: /usr/local/bin/nydusd singleton --fscache /var/lib/containerd/io.containerd.snapshotter.v1.nydus/cache --apisock /var/lib/containerd/io.containerd.snapshotter.v1.nydus/socket/cm9lkqq3cngfi05gk0mg/api.sock --log-level info --log-rotation-size 100"
/usr/local/bin/nydusd: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /usr/local/bin/nydusd)
/usr/local/bin/nydusd: /lib64/libc.so.6: version `GLIBC_2.33' not found (required by /usr/local/bin/nydusd)

Details

The rust:1.72.1 image is based on the Debian 12 bookworm, and requires an excessively high version of glibc, resulting in the inability to find the glibc version to run the compiled nydus program on some old operating systems.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

The rust:1.72.1 image is based on the Debian 12 bookworm, and requires
an excessively high version of glibc, resulting in the inability to
find the glibc version to run the compiled nydus program on some old
operating systems.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay adamqqqplay requested a review from a team as a code owner January 2, 2024 06:57
@adamqqqplay adamqqqplay requested review from bergwolf and gaius-qi and removed request for a team January 2, 2024 06:57
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f085879) 61.29% compared to head (2b0c7d8) 61.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1535      +/-   ##
==========================================
- Coverage   61.29%   61.27%   -0.02%     
==========================================
  Files         144      144              
  Lines       46597    46597              
  Branches    44133    44133              
==========================================
- Hits        28561    28554       -7     
- Misses      16589    16591       +2     
- Partials     1447     1452       +5     

see 3 files with indirect coverage changes

@Desiki-high
Copy link
Member

# install golang env
Run wget https://go.dev/dl/go1.19.linux-amd64.tar.gz \
&& tar -C /usr/local -xzf go1.19.linux-amd64.tar.gz \
&& rm -rf go1.19.linux-amd64.tar.gz

Should we also update the Golang version?

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay
Copy link
Member Author

# install golang env
Run wget https://go.dev/dl/go1.19.linux-amd64.tar.gz \
&& tar -C /usr/local -xzf go1.19.linux-amd64.tar.gz \
&& rm -rf go1.19.linux-amd64.tar.gz

Should we also update the Golang version?

@Desiki-high Thanks for your advice. I pushed a new patch to solve this problem.

Copy link
Member

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desiki-high Desiki-high merged commit 5ecda8c into dragonflyoss:master Jan 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants