Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: bump upload-artifact/download-artifact v4 #1539

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Jan 15, 2024

Relevant Issue (if applicable)

N/A.

Details

Since actions/download-artifact#249 was fixed by actions/download-artifact#274, we can use the v4 version.
download-artifact v4 is stable now.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner January 15, 2024 08:26
@Desiki-high Desiki-high requested review from bergwolf, liubin and hsiangkao and removed request for a team January 15, 2024 08:26
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9dae4ec) 61.39% compared to head (c43f796) 61.39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
- Coverage   61.39%   61.39%   -0.01%     
==========================================
  Files         144      144              
  Lines       46962    46962              
  Branches    44498    44498              
==========================================
- Hits        28833    28831       -2     
- Misses      16646    16647       +1     
- Partials     1483     1484       +1     

see 3 files with indirect coverage changes

Since actions/download-artifact#249 are fixed,
we can use the v4 version.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit a3922b8 into dragonflyoss:master Jan 17, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants