Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload-artifact v4 break changes #1542

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

ref #1541.

Details

upload-artifact v4 can't upload artifacts to the same name.
Release Test in my repo: https://github.com/Desiki-high/nydus/actions/runs/7578687509.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

upload-artifact v4 can't upload artifact to same name

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested a review from a team as a code owner January 19, 2024 02:44
@Desiki-high Desiki-high requested review from bergwolf, jiangliu and changweige and removed request for a team January 19, 2024 02:44
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f26f8e) 61.38% compared to head (7aba7da) 61.39%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1542   +/-   ##
=======================================
  Coverage   61.38%   61.39%           
=======================================
  Files         144      144           
  Lines       46962    46962           
  Branches    44498    44498           
=======================================
+ Hits        28828    28832    +4     
+ Misses      16650    16646    -4     
  Partials     1484     1484           

see 1 file with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 3f47f1e into dragonflyoss:master Jan 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants