action: use official github action for golangci-lint #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
requested review from
bergwolf,
imeoer and
gaius-qi
and removed request for
a team
Desiki-high
force-pushed
the
golangci-lint-action
branch
2 times, most recently
from
00917aa to
6fc67be
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
=======================================
Coverage 61.39% 61.39%
=======================================
Files 144 144
Lines 46962 46962
Branches 44498 44498
=======================================
Hits 28832 28832
Misses 16646 16646
Partials 1484 1484
|
adamqqqplay
reviewed
Feb 20, 2024
Desiki-high
force-pushed
the
golangci-lint-action
branch
2 times, most recently
from
54598c5 to
1350827
Compare
1. Use the official GitHub action for golangci-lint from its authors. 2. fix golang lint error with v1.56 3. separate test and golang lint.Sometimes we need tests without golang lint and sometimes we just want to do golang lint. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
golangci-lint-action
branch
from
1350827 to
e14263a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
N/A.
Details
contrib-lint.golangci-lintmanually.Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.