Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats test: add a backup image to avoid network errors #1567

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

In some cases, the image source provided by ghcr.io is not very stable and may cause the test to fail.

Details

This patch adds a backup image to avoid network errors. When the test fails, the backup image is retried.

Test passed in: https://tone.openanolis.cn/ws/nrh4nnio/test_result/117548?tab=1
test

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@adamqqqplay adamqqqplay requested a review from imeoer April 8, 2024 08:26
@adamqqqplay adamqqqplay requested a review from a team as a code owner April 8, 2024 08:26
@adamqqqplay adamqqqplay requested review from ccx1024cc and hsiangkao and removed request for a team April 8, 2024 08:26
@yqleng1987
Copy link
Contributor

Test passed!
image

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay
Copy link
Member Author

Codecov CI are broken and can be ignored for now.

@adamqqqplay adamqqqplay merged commit 9826b2c into dragonflyoss:master Apr 9, 2024
23 of 24 checks passed
@adamqqqplay adamqqqplay deleted the update-bats-image branch April 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants