fix: add namespace flag for nydusify commit. #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerseidMeteor
requested review from
bergwolf,
imeoer and
power-more
and removed request for
a team
|
PTAL :) @imeoer |
imeoer
reviewed
Jul 8, 2024
| @@ -84,7 +85,7 @@ func (cm *Committer) Commit(ctx context.Context, opt Opt) error { | |||
| return errors.Wrap(err, "parse target image name") | |||
| } | |||
|
|
|||
| inspect, err := cm.manager.Inspect(ctx, opt.ContainerID) | |||
| inspect, err := cm.manager.Inspect(ctx, opt.ContainerID, opt.Namespace) | |||
There was a problem hiding this comment.
How about calling ctx = namespaces.WithNamespace(ctx, namespace) before here.
There was a problem hiding this comment.
How about calling in nydusify.go main func?
Just at return cm.Commit(c.Context, opt)
There was a problem hiding this comment.
Better to put it in committer.go, so we can import it as a package in other project. :)
PerseidMeteor
force-pushed
the
fix-namespace-miss
branch
from
4e1aafe
to
2076963
Compare
Signed-off-by: YuQiang <yu_qiang@mail.nwpu.edu.cn>
|
thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#1596
Details
Add
namespaceflag fornydusify commit.Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.