Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: upgrade macos to 12 #1601

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

image

Details

macos-11 was deprecated since 2024.06.28.
https://docs.github.com/actions/using-jobs/choosing-the-runner-for-a-job

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner July 13, 2024 12:21
@Desiki-high Desiki-high requested review from liubogithub, jiangliu and changweige and removed request for a team July 13, 2024 12:21
@Desiki-high
Copy link
Member Author

Since pull request doesn't have permission to access the secrets, so upload-coverage-to-codecov failed. This is a bug of https://github.com/codecov/codecov-action/. upload-coverage-to-codecov can work well in the upstream repo because the master branch has permission to read the correct secret. cc @imeoer

macos-11 was deprecated since 2024.06.28.
https://docs.github.com/actions/using-jobs/choosing-the-runner-for-a-job

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.42%. Comparing base (3684474) to head (12353f5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
- Coverage   61.43%   61.42%   -0.02%     
==========================================
  Files         145      145              
  Lines       48032    48032              
  Branches    46007    46007              
==========================================
- Hits        29508    29502       -6     
- Misses      16963    16968       +5     
- Partials     1561     1562       +1     

see 3 files with indirect coverage changes

@Desiki-high
Copy link
Member Author

Desiki-high commented Jul 14, 2024

Since pull request doesn't have permission to access the secrets, so upload-coverage-to-codecov failed. This is a bug of https://github.com/codecov/codecov-action/. upload-coverage-to-codecov can work well in the upstream repo because the master branch has permission to read the correct secret. cc @imeoer

Fixed in 12353f5.

@Desiki-high Desiki-high requested a review from imeoer July 14, 2024 02:34
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@imeoer imeoer merged commit 32b6ead into dragonflyoss:master Jul 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants