Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]External blob #1672

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP]External blob #1672

wants to merge 7 commits into from

Conversation

BraveY
Copy link

@BraveY BraveY commented Feb 28, 2025

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@BraveY BraveY requested a review from a team as a code owner February 28, 2025 04:48
@BraveY BraveY requested review from bergwolf, imeoer and Desiki-high and removed request for a team February 28, 2025 04:48
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 10.25112% with 2609 lines in your changes missing coverage. Please review.

Project coverage is 53.08%. Comparing base (dd9ba54) to head (24a62f1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nydusify/pkg/snapshotter/converter/convert_unix.go 0.00% 978 Missing ⚠️
contrib/nydusify/pkg/converter/converter.go 0.00% 283 Missing ⚠️
...nydusify/pkg/snapshotter/converter/tool/builder.go 0.00% 279 Missing ⚠️
contrib/nydusify/pkg/external/modctl/modctl.go 0.00% 193 Missing ⚠️
...ontrib/nydusify/pkg/snapshotter/converter/utils.go 0.00% 128 Missing ⚠️
...ydusify/pkg/snapshotter/converter/cs_proxy_unix.go 0.00% 116 Missing ⚠️
...rib/nydusify/pkg/snapshotter/external/generator.go 0.00% 99 Missing ⚠️
...ydusify/pkg/snapshotter/external/backend/walker.go 0.00% 94 Missing ⚠️
builder/src/directory.rs 0.00% 84 Missing ⚠️
...trib/nydusify/pkg/snapshotter/external/external.go 0.00% 42 Missing ⚠️
... and 23 more

❗ There is a different number of reports uploaded between BASE (dd9ba54) and HEAD (24a62f1). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (dd9ba54) HEAD (24a62f1)
9 1
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
- Coverage   60.42%   53.08%   -7.35%     
==========================================
  Files         146      202      +56     
  Lines       48943    56188    +7245     
  Branches    46380    46835     +455     
==========================================
+ Hits        29573    29826     +253     
- Misses      17906    24883    +6977     
- Partials     1464     1479      +15     
Files with missing lines Coverage Δ
api/src/config.rs 88.78% <100.00%> (+0.03%) ⬆️
builder/src/core/bootstrap.rs 77.63% <100.00%> (+0.29%) ⬆️
builder/src/core/chunk_dict.rs 70.18% <ø> (ø)
builder/src/lib.rs 64.25% <ø> (ø)
builder/src/merge.rs 70.73% <100.00%> (ø)
builder/src/stargz.rs 75.00% <100.00%> (+0.14%) ⬆️
builder/src/tarball.rs 63.26% <100.00%> (+0.57%) ⬆️
...trib/nydusify/pkg/chunkdict/generator/generator.go 0.00% <ø> (ø)
contrib/nydusify/pkg/committer/commiter.go 0.00% <ø> (ø)
contrib/nydusify/pkg/copier/copier.go 0.00% <ø> (ø)
... and 37 more

... and 39 files with indirect coverage changes

@BraveY BraveY force-pushed the external-blob branch 4 times, most recently from e80d50c to 53e1e3f Compare February 28, 2025 17:21
- copy snapshotter code to internal package.
- add modctl handler to produce nydus attribute pattern.
- support push manifest to registry in convert

Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants